Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a vendored openssl to fix linking issues. #69

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

gl-yziquel
Copy link
Contributor

No description provided.

@gl-yziquel gl-yziquel mentioned this pull request Nov 23, 2023
@yodaldevoid
Copy link
Contributor

Similar to my feedback on a a similar PR, I would not suggest this PR is merged as is.

Changes beyond the fix in question are included in this PR. Additionally, adding a dependency on openssl is not really the correct fix here, as what really needs the vendored flag is openssl-sys. openssl just passes this flag down the chain

@gl-yziquel
Copy link
Contributor Author

Thank you for the feedback. I will consider this as soon as I find time for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants