WIP: Add ui nav history add routing #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto add-ui-nav-history
A few general upkeep items I needed to tackle in the process: * Silence loud chrome warnings in the devtools console by switching our fontawesome CDN tag to a crossorigin-friendly tag [/testplan/web_ui/testing/public/index.html]()
…h/scm/ets_testplan/testplan_oss into add-ui-nav-history--add-routing # Conflicts: # testplan/web_ui/testing/src/Nav/NavList.js
Changes include: - package.json: add lodash for uncomplicated comparison and slicing of state (and using module import so as to not bloat production bundle) - .eslintrc.json: Make eslint allow comments up to 120 characters for e.g. JSDoc examples and web links - AssertionPane.js: export aphrodite CSS for reuse - CenterPane.jsx: rewrite of GetCenterPane function in reportUtils.js - state.js: major revamp of UI state management
…nto add-ui-nav-history--add-routing
testsuites into a central place
|
closing in favor of #451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Describe routing architecture
A few general upkeep items I needed to tackle in the process:
fontawesome CDN tag to a crossorigin-friendly tag /testplan/web_ui/testing/public/index.html