Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wait_for_nothing_visible_to_be_animating for UIRefreshControl animation issue #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samst0r
Copy link

@samst0r samst0r commented Mar 13, 2014

Added wait_for_nothing_visible_to_be_animating helper method which checks for views that are animating and are also FEX_isVisible.

This resolves the issues with the UIRefreshControl (Issue #266).

…for views that are animating and are also `FEX_isVisible`.

This resolves the issues with the UIRefreshControl (Issue moredip#266).
@seanoshea
Copy link
Contributor

+1 to this.

@moredip
Copy link
Owner

moredip commented Mar 18, 2014

Thanks for the contribution. I'm not sure I like the approach of making two separate frankly_map calls and then zipping the two sets of views together. It assumes that the same set of views will come back, in the same order. That won't happen in all cases (e.g. while a screen transition is happening).

Could you approach this by adding an FEX_isAnimatingAndVisible method on the objective C side so that you could just do something like:

def wait_for_nothing_visible_to_be_animating( timeout = false )
    wait_until :timeout => timeout do
      !element_exists('view FEX_isAnimatingAndVisible')
    end
  end

@samst0r
Copy link
Author

samst0r commented Mar 18, 2014

No worries. I'll go ahead and add that into ObjC side. That's a good shout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants