Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed empty shared subscriptions list remaining forever #836

Merged

Conversation

hylkevds
Copy link
Collaborator

Even for clients that never made shared subscriptions, upon session clean, an empty shared subscriptions list was created and never removed.

Relates #734

Even for clients that never made shared subscriptions, upon session clean,
an empty shared subscriptions list was created and never removed.
Copy link
Collaborator

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andsel andsel merged commit 2092693 into moquette-io:main Apr 30, 2024
4 checks passed
@andsel
Copy link
Collaborator

andsel commented Apr 30, 2024

Thanks @hylkevds for your contribution.

@hylkevds hylkevds deleted the fix_clientSharedSubscriptionsLeak branch April 30, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants