Fixed #831: changed several cases where a shared readerIndex was changed #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hylkevds thanks for working on this fix.
You are right, should be All changes look good, but would be nice to have this covered by a unit test, because or code wasn't tested or the coverage of these lines was not so complete and the bug didn't pop up. |
DebugUtils.payload2Str set the readerIndex to the readableBytes, witch was simply wrong. Utils.readBytesAndRewind was unused and thus removed. SegmentedPersistentQueueSerDes use of readBytes (that changes the readerIndex) was changed to getBytes which does not change the readerIndex.
hylkevds
force-pushed
the
fix_831_readerIndex
branch
from
64fb475
to
7a28c1b
Compare
|
The writePayload one is testable, added a test for it. |
|
Thank's for contributing the fix @hylkevds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DebugUtils.payload2Str set the readerIndex to the readableBytes, witch was simply wrong.
Utils.readBytesAndRewind was unused and thus removed. Though it changed the readerIndex, it also reset it, but this use would still have not been thread-safe.
SegmentedPersistentQueueSerDes use of readBytes (that changes the readerIndex) was changed to getBytes which does not change the readerIndex.
Closes #831