Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

(manpages) update "HDD_LEAVE_SPACE_DEFAULT" regex to escape "." #569

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tianon
Copy link
Contributor

@tianon tianon commented Mar 6, 2024

Normally I would've combined this with #568 (caught them during the same reading), but I think this one is possibly slightly more controversial? 馃槄

This string in the documentation looks like a regular expression, which makes the unescaped . in it feel odd. I went for the "idiomatic Perl" style [.] escaping because I personally find it more readable, but I'm happy to swap to the more common \. or even just have the PR closed instead because I don't feel strongly about it at all. 馃槃

(I also double checked that the code wasn't actually using a regular expression that needed to be updated, and indeed confirmed that it has some code that does parsing and something like c == '.' for testing this case and the regex is purely documentation. 馃憤)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant