(manpages) update "HDD_LEAVE_SPACE_DEFAULT" regex to escape "." #569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally I would've combined this with #568 (caught them during the same reading), but I think this one is possibly slightly more controversial? 馃槄
This string in the documentation looks like a regular expression, which makes the unescaped
.
in it feel odd. I went for the "idiomatic Perl" style[.]
escaping because I personally find it more readable, but I'm happy to swap to the more common\.
or even just have the PR closed instead because I don't feel strongly about it at all. 馃槃(I also double checked that the code wasn't actually using a regular expression that needed to be updated, and indeed confirmed that it has some code that does parsing and something like
c == '.'
for testing this case and the regex is purely documentation. 馃憤)