Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Needs review] New "Profiles" functionality #919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fidelix
Copy link

@fidelix fidelix commented Jan 18, 2021

Solves https://ideas.moonlight-stream.org/posts/25/per-game-settings

It lets you save/remove profiles, as well as assign a profile per app.
It can probably be improved to be per hostId+app instead, as well as allowing switching profiles globally (perhaps a quick floating button to select global profile). But I'd say this is a good start.

NOTE:
This is my first android code. This is also my first java code. It will probably be rubbish, so please be patient, tell me the "java" way and I will do my best to fix things.

Screenshots of the UX
image

image

image

@8116453
Copy link

8116453 commented Jan 19, 2021

Is it convenient to add the switch to turn on and off the virtual controller and switch the operation mode of mouse and touch in the quick hover button?

@fidelix
Copy link
Author

fidelix commented Jan 19, 2021

Is it convenient to add the switch to turn on and off the virtual controller and switch the operation mode of mouse and touch in the quick hover button?

This can certainly be done, but it's not related to profiles or this PR. What you're asking simply sounds like a quick toggle for those settings, globally.

@8116453
Copy link

8116453 commented Jan 20, 2021

I think your idea of floating window is very good. If you can add more functions to it, will it be more perfect

@ikogan
Copy link

ikogan commented Feb 17, 2021

Not sure if this is currently already implemented but being able to select "Remote Desktop" mouse mode per game would be great as well.

@fidelix
Copy link
Author

fidelix commented Feb 17, 2021

@ikogan it's possible with this PR.

It's just waiting for the review of a maintainer.

@fidelix fidelix changed the title WIP: New "Profiles" functionality [Needs review] New "Profiles" functionality Feb 19, 2021
@cgutman cgutman self-assigned this Feb 27, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jul 21, 2021
@cgutman cgutman added enhancement and removed stale labels Jul 21, 2021
@ikogan
Copy link

ikogan commented Jul 21, 2021

Is it possible to review and merge the PR that solves this?

@jonathanmassehsj
Copy link
Contributor

@cgutman any review about this?

@chancemon
Copy link

chancemon commented Jul 5, 2022

This is brilliant. I want this so bad! @fidelix Is your code still up-to-date still? I may need to patch this in myself.

@Nonary
Copy link
Contributor

Nonary commented Jul 14, 2022

Note: I am not a maintainer and have no authority in approving the pull request, just offering my opinion on this manner.

While this pull request does actually accomplish adding profiles, I don't think it has enough polish to consider being merged into master just yet.

Secondly, because this this is a highly rated feature, we will most certainly have to port this over to iOS and preferably at the same time so both platforms benefit. I'm not familiar with Swift but am committed to learning a bit of it to see if I can get this done on iOS but can't make any promises in terms of how long. iOS also has strict guidelines of exactly how the UI should be and may pose challenges, not sure just yet.

Also by design of this application, settings are applied immediately with no confirmation prompts of any kind. The current state of this code is completely different and expects you to hit save in order to apply changes and it is also rather blind in a sense where you can't see the profile settings, you're only allowed to overwrite it.

Therefore, if we were to implement profile selection it should be designed in a way where after the user picks the profile in the dropdown, any changes they make on that screen will automatically be saved without any confirmation, while also still being "attached" to any assigned applications.

I will be working in polishing it up to be what I am describing here and I'll re-submit the pull request when the time comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants