Improve build instructions in README.md #1315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentyman23
changed the title
| @@ -3,26 +3,43 @@ | |||
| [](https://ci.appveyor.com/project/cgutman/moonlight-android/branch/master) | |||
| [](https://hosted.weblate.org/projects/moonlight/moonlight-android/) | |||
|
|
|||
| [Moonlight for Android](https://moonlight-stream.org) is an open source client for NVIDIA GameStream and [Sunshine](https://github.com/LizardByte/Sunshine). | |||
| [Moonlight](https://moonlight-stream.org/) for Android is an open source client for | |||
| [Nvidia GameStream](https://www.nvidia.com/en-us/support/gamestream/) and | |||
There was a problem hiding this comment.
Is there value in linking to a dead service?
There was a problem hiding this comment.
Maybe not, but I figured since people still get support in #geforce-experience in Discord that maybe we weren't ready to stop mentioning it. I defer to the maintainer.
kentyman23
commented
Jan 19, 2024
| ## Building | ||
| * Install Android Studio and the Android NDK | ||
| * Run ‘git submodule update --init --recursive’ from within moonlight-android/ | ||
| * In moonlight-android/, create a file called ‘local.properties’. Add an ‘ndk.dir=’ property to the local.properties file and set it equal to your NDK directory. |
There was a problem hiding this comment.
Can I get confirmation from someone with more Android development experience that we can indeed totally remove the need for local.properties given the instructions I laid out. It seemed to work on my machine, but I want to make sure there are no side effects I'm not considering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
README.mdwith more explicit instructions on installing the NDK to ensure others don't run into issues I had when first starting. I also was able to remove warnings about deprecated use oflocal.propertiesto point to the NDK. While I was at it, I made various small wording/formatting tweaks to the file.