Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove image for foundry tutorial #924

Merged
merged 1 commit into from May 14, 2024
Merged

Conversation

wuzhong-papermoon
Copy link
Contributor

Description

Images in foundry tutorial should be removed after the PR for chinese version is merged. All images are replaced with terminal snippet.

Checklist

  • [βœ”] I have added a label to this PR 🏷️
  • [ βœ”] I have run my changes through Grammarly
  • [ βœ”] If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • [βœ” ] If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • [ βœ”] If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • [βœ” ] After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • [βœ” ] If images have been added, I have run the compress-images.py script to compress the images.
  • [βœ” ] If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • [ βœ”] If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • [βœ” ] Will need to create PR in moonbeam-docs repo to remove images
  • [ βœ”] Will need to create PR in moonbeam-docs repo to remove variables
  • [βœ” ] Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • [ βœ”] No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

Images in foundry tutorial should be removed after the PR for chinese version is merged. All images are replaced with terminal snippet. moonbeam-foundation/moonbeam-docs-cn#425
@wuzhong-papermoon wuzhong-papermoon added the A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) label May 10, 2024
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweeet! thanks! πŸš€

@eshaben
Copy link
Contributor

eshaben commented May 14, 2024

waiting to merge this til moonbeam-foundation/moonbeam-docs-cn#425 is merged

@wuzhong-papermoon wuzhong-papermoon merged commit 42fcb61 into master May 14, 2024
1 check passed
@eshaben eshaben deleted the remove-foundry-image branch May 14, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants