New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sidecar version to 18.0.0 #919
Conversation
Update sidecar version to 18.0.0 from 14.1.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first image on the sidecar page shows version 14.1.1. It'd be great if this could be changed to a terminal snippet (like this) and updated to show version 18.0.0 please!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor feedback
.snippets/code/builders/get-started/networks/moonbeam-dev/terminal/sidecar.md
Outdated
Show resolved
Hide resolved
.snippets/code/builders/get-started/networks/moonbeam-dev/terminal/sidecar.md
Outdated
Show resolved
Hide resolved
β¦inal/sidecar.md Co-authored-by: albertov19 <64150856+albertov19@users.noreply.github.com>
β¦inal/sidecar.md Co-authored-by: albertov19 <64150856+albertov19@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!
.snippets/code/builders/get-started/networks/moonbeam-dev/terminal/sidecar.md
Outdated
Show resolved
Hide resolved
.snippets/code/builders/get-started/networks/moonbeam-dev/terminal/sidecar.md
Outdated
Show resolved
Hide resolved
β¦inal/sidecar.md Co-authored-by: Erin Shaben <eshaben@icloud.com>
β¦inal/sidecar.md Co-authored-by: Erin Shaben <eshaben@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks! β¨
@albertov19 your feedback was addressed, can you please approve? π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Update Sidecar version to 18.0.0
Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in Jiramoonbeam-mkdocs
to update redirectsmove-pages.py
script to move the pages and update the image paths on the chinese repomoonbeam-docs-cn
compress-images.py
script to compress the images.moonbeam-docs-cn
repo to use the new variablesCorresponding PRs
Please link to any corresponding PRs here.
After Translation Requirements
moonbeam-docs
repo to remove imagesmoonbeam-docs
repo to remove variablesmoonbeam-mkdocs
repo to add redirects for Chinese siteItems to be Updated
Please list any of the items that will need to be added or deleted after the translations are done here.