Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sidecar version to 18.0.0 #919

Merged
merged 9 commits into from May 8, 2024

Conversation

wuzhong-papermoon
Copy link
Contributor

Description

Update Sidecar version to 18.0.0

Checklist

  • [βœ” ] I have added a label to this PR 🏷️
  • [ βœ”] I have run my changes through Grammarly
  • [ βœ”] If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • [ βœ”] If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • [βœ” ] If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • [ βœ”] After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • [ βœ”] If images have been added, I have run the compress-images.py script to compress the images.
  • [βœ” ] If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • [ βœ”] If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • [ βœ”] Will need to create PR in moonbeam-docs repo to remove images
  • [βœ” ] Will need to create PR in moonbeam-docs repo to remove variables
  • [ βœ”] Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • [ βœ”] No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@wuzhong-papermoon wuzhong-papermoon added the A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.) label May 2, 2024
albertov19
albertov19 previously approved these changes May 2, 2024
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first image on the sidecar page shows version 14.1.1. It'd be great if this could be changed to a terminal snippet (like this) and updated to show version 18.0.0 please!

@albertov19 albertov19 dismissed their stale review May 3, 2024 11:55

Erin's image comment

Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor feedback

wuzhong-papermoon and others added 2 commits May 7, 2024 22:17
…inal/sidecar.md

Co-authored-by: albertov19 <64150856+albertov19@users.noreply.github.com>
…inal/sidecar.md

Co-authored-by: albertov19 <64150856+albertov19@users.noreply.github.com>
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

wuzhong-papermoon and others added 2 commits May 8, 2024 15:25
…inal/sidecar.md

Co-authored-by: Erin Shaben <eshaben@icloud.com>
…inal/sidecar.md

Co-authored-by: Erin Shaben <eshaben@icloud.com>
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! ✨

@eshaben eshaben requested a review from albertov19 May 8, 2024 13:53
@eshaben
Copy link
Contributor

eshaben commented May 8, 2024

@albertov19 your feedback was addressed, can you please approve? πŸ™‚

Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshaben eshaben merged commit db18d27 into moonbeam-foundation:master May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3 - Quick Fixes Pull request contains small fixes (i.e., fixing a typo, removing old images, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants