New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hardhat Tutorials to Use Hardhat Ignition Modules #902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweeeet!! A couple things:
- I applied feedback on the dev-environments/hardhat page that should also be applied to the tutorial
- We have to keep the CN site in working order, so we need to keep the images. Make sure to update the checklist to reflect that the images need to be removed post-translation.
.snippets/code/builders/pallets-precompiles/precompiles/staking/StakingInterface.sol
Outdated
Show resolved
Hide resolved
.snippets/code/builders/build/eth-api/dev-env/hardhat/terminal/interact.md
Outdated
Show resolved
Hide resolved
.snippets/code/builders/build/eth-api/dev-env/hardhat/terminal/interact.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Erin Shaben <eshaben@icloud.com>
…g/StakingInterface.sol Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some of the images still need to be restored for the chinese docs.
Can you just go through and make sure all the snippets in the hardhat tutorial have been cleaned up with prettier? Also take a look at the really long comments and how those are displayed on the actual page. If it makes sense or looks better to break them up yourself, please do that.
Thanks!
.snippets/code/tutorials/eth-api/hardhat-start-to-end/terminal/deploy-moonbase.md
Outdated
Show resolved
Hide resolved
.snippets/code/tutorials/eth-api/hardhat-start-to-end/terminal/deploy-moonbeam.md
Outdated
Show resolved
Hide resolved
…/deploy-moonbase.md Co-authored-by: Erin Shaben <eshaben@icloud.com>
…/deploy-moonbeam.md Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Cn images are all added back, none are removed in this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of minor things, but looks good!!
.snippets/code/tutorials/eth-api/hardhat-start-to-end/.prettierrc.js
Outdated
Show resolved
Hide resolved
.snippets/code/tutorials/eth-api/hardhat-start-to-end/dao-js-test-file.js
Outdated
Show resolved
Hide resolved
…est-file.js Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✨
Description
This tutorial freshens up Hardhat tutorials to use Ignition modules to deploy smart contracts. Additionally, the Hardhat End to End tutorial was freshened up with some revised contract code and updated collators. Also updates terminal screenshots to terminyl.
Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in Jiramoonbeam-mkdocs
to update redirectsmove-pages.py
script to move the pages and update the image paths on the chinese repomoonbeam-docs-cn
compress-images.py
script to compress the images.moonbeam-docs-cn
repo to use the new variablesCorresponding PRs
Please link to any corresponding PRs here.
After Translation Requirements
moonbeam-docs
repo to remove imagesmoonbeam-docs
repo to remove variablesmoonbeam-mkdocs
repo to add redirects for Chinese siteItems to be Updated
Please list any of the items that will need to be added or deleted after the translations are done here.