New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding article for new relay data verifier precompile #898
Conversation
…DataVerifier-precompile Adding relay data verifier precompile article
@wuzhong-papermoon next time please ensure the Checklist for each PR is not deleted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! There are lots of little things that I look for when reviewing PRs so there are a lot of comments on these little things.
Generally, these are the things that you should do before submitting a PR:
- Format code with Prettier or Black Formatter (for Python)
- Run your writing through Grammarly to check for spelling, grammar, and general improvements like clarity, etc.
The other little things that I nitpick about are things that you'll pick up on over time! 🙂
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
…DataVerifier-precompile update relay data verifier precompile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing capital first letter in a list
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
builders/pallets-precompiles/precompiles/relay-data-verifier.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding a new article for relay data verifier precompile