Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding article for new relay data verifier precompile #898

Merged
merged 10 commits into from Apr 5, 2024

Conversation

wuzhong-papermoon
Copy link
Contributor

Adding a new article for relay data verifier precompile

@wuzhong-papermoon wuzhong-papermoon added the A0 - New Content Pull request contains new content pages label Apr 2, 2024
@albertov19 albertov19 requested a review from eshaben April 2, 2024 16:58
@albertov19
Copy link
Contributor

@wuzhong-papermoon next time please ensure the Checklist for each PR is not deleted

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! There are lots of little things that I look for when reviewing PRs so there are a lot of comments on these little things.

Generally, these are the things that you should do before submitting a PR:

  • Format code with Prettier or Black Formatter (for Python)
  • Run your writing through Grammarly to check for spelling, grammar, and general improvements like clarity, etc.

The other little things that I nitpick about are things that you'll pick up on over time! 🙂

Copy link
Contributor Author

@wuzhong-papermoon wuzhong-papermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing capital first letter in a list

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshaben eshaben merged commit f2549e3 into moonbeam-foundation:master Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0 - New Content Pull request contains new content pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants