Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docs on GMP vs XCM #895
Add Docs on GMP vs XCM #895
Changes from 2 commits
fa6d619
ce38c1b
516f66a
ca9ef0a
1b8ae63
5486bcb
3251b0d
a350dbf
ab9efb0
c0d77bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm struggling with this section because I feel like it just duplicates content that we already have on the XCM Overview page.
I do really like the "Happy Path of a Cross-Chain Message" section under GMP, and so I'm thinking that we should try to keep the XCM and GMP sections like apples to apples and have the same sort of section under XCM. Maybe because this content is structured pretty closely to how it is on the overview page, that's where my problem lies, and if we can make it more casual here, and layout the flow of a cross-chain transaction via VMP and then also via HRMP in a similar manner that might be beneficial.
I don't know 🤷♀️ -- what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simplified it a bit to get rid of the XCM overview section and shuffled some things around, also putting the quick reference table in above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!