New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moonbeam vs Ethereum reorg #888
Conversation
(to be moved later)
- rename a few sections - move the ethereum rpc and moonbeam api to the protocol functionality section - add a page on creating an account to the get started section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think this could go in with a larger effort on removing some old pages on Platform?
I think we discussed this. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed 1 commit, looks good!
Yeah, I think we discussed this a while ago. But at this point, I would say separately from this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I tested this with the respective branch of mkdocs corresponding to this pr and the core concepts logo looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Are we doing redirects for such large changes?
redirects added ✅ thanks! |
This has been like this for 5 months 🤯 😂 good catch!! The other thing is in the mkdocs PR that I linked to in my last comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR moves the Moonbeam vs Ethereum content to a new section called Core Concepts. It also cleans up the overlap in the Ethereum-related content so that the underlying technology and architecture all lives on the Technology & Architecture page and the Ethereum Compatibility page in the Features section highlights Moonbeam's Ethereum compatibility and also some key differences.
Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in Jiramoonbeam-mkdocs
to update redirectsCorresponding PRs
Please link to any corresponding PRs here.
After Translation Requirements
moonbeam-mkdocs
repo to add redirects for Chinese site