Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moonbeam vs Ethereum reorg #888

Merged
merged 23 commits into from May 3, 2024
Merged

Moonbeam vs Ethereum reorg #888

merged 23 commits into from May 3, 2024

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Mar 15, 2024

Description

This PR moves the Moonbeam vs Ethereum content to a new section called Core Concepts. It also cleans up the overlap in the Ethereum-related content so that the underlying technology and architecture all lives on the Technology & Architecture page and the Ethereum Compatibility page in the Features section highlights Moonbeam's Ethereum compatibility and also some key differences.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site

- rename a few sections
- move the ethereum rpc and moonbeam api to the protocol functionality section
- add a page on creating an account to the get started section
@eshaben eshaben added the A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) label Mar 15, 2024
@eshaben eshaben mentioned this pull request Mar 15, 2024
5 tasks
@eshaben eshaben changed the title Eshaben/moonbeam vs eth Moonbeam vs Ethereum reorg Mar 15, 2024
albertov19
albertov19 previously approved these changes Mar 19, 2024
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think this could go in with a larger effort on removing some old pages on Platform?

I think we discussed this. Wdyt?

themacexpert
themacexpert previously approved these changes Mar 22, 2024
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed 1 commit, looks good!

@eshaben
Copy link
Contributor Author

eshaben commented Mar 25, 2024

LGTM!

I think this could go in with a larger effort on removing some old pages on Platform?

I think we discussed this. Wdyt?

Yeah, I think we discussed this a while ago. But at this point, I would say separately from this PR

themacexpert
themacexpert previously approved these changes Mar 25, 2024
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested this with the respective branch of mkdocs corresponding to this pr and the core concepts logo looks great.

albertov19
albertov19 previously approved these changes Apr 24, 2024
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Are we doing redirects for such large changes?

@eshaben eshaben dismissed stale reviews from albertov19 and themacexpert via aa237e0 April 30, 2024 19:55
@eshaben
Copy link
Contributor Author

eshaben commented Apr 30, 2024

redirects added ✅ thanks!
papermoonio/moonbeam-mkdocs#181

@themacexpert
Copy link
Contributor

Couple quick things I noticed the icon here is missing Screenshot 2024-04-30 at 5 48 34 PM

@themacexpert
Copy link
Contributor

And Subwallet has a duplicate page
Screenshot 2024-04-30 at 5 50 39 PM

themacexpert
themacexpert previously approved these changes May 1, 2024
@eshaben
Copy link
Contributor Author

eshaben commented May 1, 2024

And Subwallet has a duplicate page

This has been like this for 5 months 🤯 😂 good catch!! The other thing is in the mkdocs PR that I linked to in my last comment

@eshaben eshaben requested a review from themacexpert May 1, 2024 01:32
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshaben eshaben merged commit 443e5ba into master May 3, 2024
1 check passed
@eshaben eshaben deleted the eshaben/moonbeam-vs-eth branch May 3, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants