Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Subsquid-related docs #584

Merged
merged 11 commits into from Mar 28, 2023
Merged

Update Subsquid-related docs #584

merged 11 commits into from Mar 28, 2023

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Mar 13, 2023

Description

This PR adds a new page to the tutorials section with Massimo's how to index NFT transfers with Subsquid tutorial. It also replaces the old subsquid page with a quick get started page for indexing EVM and Substrate data with Subsquid.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove snippets

Items to be Updated

Snippet to be removed:

  • code/subsquid/erc721.md

Images to be removed:

  • builders/integrations/indexers/subsquid/subsquid-1.png
  • builders/integrations/indexers/subsquid/subsquid-2.png
  • builders/integrations/indexers/subsquid/subsquid-3.png

@eshaben eshaben requested a review from albertov19 March 13, 2023 19:12
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I made a commit with some direct edits as some code snippers were not being propertly rendered


Before we begin defining the mapping logic of the squid, we are going to rewrite the `src/contracts.ts` utility module for managing the involved EVM contracts. It will export:

* Addresses of [Gromlins](https://moonscan.io/token/0xf27a6c72398eb7e25543d19fda370b7083474735){target=_blank} contract
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Gromlins here? I would clarify that this is the contract used as an example

Copy link
Contributor Author

@eshaben eshaben Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the contracts.ts file so that it automatically uses the Gromlins contract instead of the 0x000000... placeholder. But yeah it's just the contract that Massimo chose

@eshaben eshaben merged commit 3ab32e9 into master Mar 28, 2023
1 check passed
@eshaben eshaben deleted the eshaben/subsquid branch March 28, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants