Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page on sending ERC-20s via XCM #582

Merged
merged 38 commits into from Apr 27, 2023
Merged

Add page on sending ERC-20s via XCM #582

merged 38 commits into from Apr 27, 2023

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Mar 10, 2023

Description

This adds a new page to the XC-20s section of the docs on how to send ERC-20s using the X-Tokens Pallet and Precompile. It also moves away from mintable xc-20s, favoring local xc-20s instead.

Still need to figure out the naming situation but for now just referring to regular old ERC-20s as ERC-20s... groundbreaking, I know.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • Add redirects

After Translation Requirements

  • Add redirects to mkdocs-cn for xc-20.md
  • Remove images that are no longer being used (polkadot.js apps)
  • Remove index page and banner image for xc-20s page

@eshaben eshaben requested a review from albertov19 March 10, 2023 16:48
@albertov19
Copy link
Contributor

Hey because this is still being worked on right now, let's convert this into a draft

@albertov19 albertov19 marked this pull request as draft March 27, 2023 13:38
@eshaben
Copy link
Contributor Author

eshaben commented Apr 20, 2023

Once other XCM pages are updated to XCM v3, I'll circle back to update the send-erc20s.md file to include these snippets: 'text/xcm/xcm-precompile-multilocation.md' and 'text/xc-20/xtokens/multilocation-structures.md'. Didn't want to go down the rabbit hole of updating these snippets and the pages they are on in this PR

@eshaben eshaben marked this pull request as ready for review April 20, 2023 15:00
@eshaben
Copy link
Contributor Author

eshaben commented Apr 22, 2023

@albertov19 this can be reviewed. I only updated the new page to reflect changes to XCM v3. I've been making changes to other related pages in another branch, so I'll open another PR for those pages 🙂

@eshaben
Copy link
Contributor Author

eshaben commented Apr 25, 2023

With all the changes I ended up moving the xtokens v3 update into this PR 😅

@albertov19 ready for review again

Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's doo iitttttt!

@albertov19
Copy link
Contributor

@eshaben I've approved the PR, please check my commits just to check everything looks good :)

@eshaben
Copy link
Contributor Author

eshaben commented Apr 27, 2023

This PR can be merged once this one is approved: moonbeam-foundation/moonbeam-docs-cn#276

@eshaben eshaben merged commit 132fc63 into master Apr 27, 2023
1 check passed
@eshaben eshaben deleted the eshaben/rt2200-xcm branch April 27, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants