New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardhat Developer Workflow Tutorial #524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of ground to cover with this tutorial! 😅 I really like how in-depth you went with the testing sections!
To try and align this with the Foundry and Truffle guides, the testing section needs to come before deployment and verification. In addition, there needs to be some sort of like TestNet to MainNet progression. So, with the other guides there are two deployment sections: one for Moonbase Alpha and one for Moonbeam MainNet and I think that is what is needed here so the deployment and verification happens on both networks. I would also reference those tutorials and the section headers to try and closely align them where it makes sense.
Are fixtures just kind of like beforeEach()
in Mocha, where setup happens for the tests? Or is there more to it? Because I feel like I was expecting there to be more to it but in the examples it just seems like general setup
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
@eshaben Thank you for the detailed feedback, I think everything is sorted now 😄 |
We're almost there! Left a few comments... but in general I think it would be helpful to do a final walk through of the tutorial yourself to make sure it flows 🙂 |
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
Co-authored-by: Erin Shaben <eshaben@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! Nice work on this one!! 🚀
LGTM ✨ 🚢
Description
Adds Hardhat Developer Workflow Tutorial for the Tutorials section.
@eshaben you're coauthor because a lot of the hardhat stuff is re-used snippets
https://purestake.atlassian.net/browse/MD-1138 is the ticket for the translations
Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in Jiramoonbeam-mkdocs
to update redirectsmove-pages.py
script to move the pages and update the image paths on the chinese repomoonbeam-docs-cn
compress-images.py
script to compress the images.moonbeam-docs-cn
repo to use the new variablesCorresponding PRs
Please link to any corresponding PRs here.
After Translation Requirements
moonbeam-docs
repo to remove imagesmoonbeam-docs
repo to remove variablesmoonbeam-mkdocs
repo to add redirects for Chinese siteItems to be Updated
Please list any of the items that will need to be added or deleted after the translations are done here.