Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate hardhat page updates, PR 785/806 #405

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wuzhong-papermoon
Copy link
Contributor

Copy link
Contributor Author

@wuzhong-papermoon wuzhong-papermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typo fixed.

builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
Co-authored-by: wuzhong-papermoon <144415646+wuzhong-papermoon@users.noreply.github.com>
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good! Just a few things need to be fixed 🙂

builders/build/eth-api/dev-env/hardhat.md Show resolved Hide resolved
builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
builders/build/eth-api/dev-env/hardhat.md Outdated Show resolved Hide resolved
@eshaben
Copy link
Contributor

eshaben commented Feb 1, 2024

@wuzhong-papermoon there are some merge conflicts too, can you please resolve those? if you have any questions or want to walk through that process together, let me know!

@eshaben
Copy link
Contributor

eshaben commented May 10, 2024

@wuzhong-papermoon more changes were made to the hardhat pages in this PR

It might be good to just do a quick scan over the page to make sure we didn't forget anything/in case anything else needs to be updated

Update Hardhat Tutorials to Use Hardhat Ignition Modules
#902
@wuzhong-papermoon
Copy link
Contributor Author

Hey @eshaben , I pushed a new commit with hardhat ignition contents. Would you take a look please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants