An Introduction to reactjs-boilerplate roadmap

[jinmayamashita]

Let's talk about our Roadmap in this PR. (as mentioned here)
Are there any required or unnecessary items in the Roadmap?
https://github.com/monstar-lab-oss/reactjs-boilerplate/pull/27/files

@mvn-luanvu-hn @yannde @mvn-binhnguyen-hn @don-wang
FYI @n-igarashi @yukinoda

[mvn-luanvu-hn]

@jinmayamashita I think we should add end-to-end testing too

[jinmayamashita]

@mvn-luanvu-hn Indeed. 👍 Do you have any tools you would recommend?

e.g TestCafe, Playwright

[mvn-luanvu-hn]

@jinmayamashita I hear about cypress a lot. Maybe we can consider it.
But currently it does not support Safari

[yannde]

@jinmayamashita @mvn-luanvu-hn
Storybook uses playwright for its interaction testing, so we could experiment with that. I've included a simple test in the vue boilerplate.

[jinmayamashita]

@mvn-luanvu-hn @yannde
DONE d0a398e

I have not used Cypress yet and would like to try it out. and we uses Storybook in boilerplate, so I would like to try working with playwright. This looks like another good PR.

[mvn-luanvu-hn]

@jinmayamashita I see in our project another team is using this tool
https://codecept.io/basics/#architecture
It can work well with many other tools

[jinmayamashita]

@mvn-luanvu-hn Nice! This may also work with playwright 👍

[yukinoda]

Ignore this comment if it has been discussed already...

How about Formik and Yup? It is common using this combination for forms

[jinmayamashita]

@yukinoda
Sorry for the late reply. I adopted react-hook-form for its ability to prevent unnecessary re render, does Formik have the same support? and I think react-hook-form can also do Yup and combination.

const validationSchema = yup.object().shape({
  email: yup.string().required('error message').email('error message'),
  password: yup.string().required('error message').min(6, 'error message')
})

const { register, setValue, handleSubmit, errors } = useForm({ validationSchema })

[yukinoda]

Left some comments...
And, let's include create CONTRIBUTING.md and setup LICENSE to the roadmap as it would be an OSS 😎

[mvn-luanvu-hn]

@jinmayamashita I think we can split folders into modules like the admin template

[jinmayamashita]

@mvn-luanvu-hn It seems like a good thing to consider. Let's keep discussing the folder structure!

[yannde]

LGTM

[jinmayamashita]

@yannde @mvn-luanvu-hn @mvn-binhnguyen-hn
FYI @n-igarashi
It has been approved, but we're not quite ready for until the merge? 🤔