Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr Added a new english quote #5345

Closed
wants to merge 2 commits into from
Closed

Conversation

Matratj
Copy link

@Matratj Matratj commented Apr 29, 2024

Description

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Apr 29, 2024
Copy link
Contributor

github-actions bot commented Apr 29, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "impr Added a new english quote". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - build
 - chore
 - ci
 - docs
 - feat
 - impr
 - fix
 - perf
 - refactor
 - revert
 - style
 - test

@Matratj Matratj changed the title Added a new english quote -impr Added a new english quote Apr 29, 2024
@Matratj Matratj changed the title -impr Added a new english quote impr Added a new english quote Apr 29, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8885679355

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8914857406

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label May 2, 2024
@Miodec
Copy link
Member

Miodec commented May 2, 2024

Please fix title and resolve conflicts.

Copy link
Contributor

github-actions bot commented May 9, 2024

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label May 9, 2024
@github-actions github-actions bot closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff Stale Has not been updated in a while waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants