Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(language): remove non-words from russian 375k (SheezZarR) #5341

Merged
merged 1 commit into from May 2, 2024

Conversation

SheezZarR
Copy link
Contributor

Description

Hello! I've stumbled upon not really words in the data. Some of them about Crimea/Russia, the other ones about a famous person in Russia.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Follow-up Question

Should the file russian_375k.json contain first/last names? I've seen a few last names in there. Maybe we should remove them too?

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Apr 27, 2024
@Miodec Miodec changed the title fix(ru-lang): remove non-words (SheezZarR) impr(language): remove non-words from russian 375k (SheezZarR) May 2, 2024
@Miodec Miodec merged commit 3121ad1 into monkeytypegame:master May 2, 2024
8 checks passed
@Miodec
Copy link
Member

Miodec commented May 2, 2024

Thanks

Miodec pushed a commit to StickminBruv/monkeytype that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants