Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impr(themes): added and Created new theme (StickminBruv) #5340

Closed
wants to merge 52 commits into from
Closed

impr(themes): added and Created new theme (StickminBruv) #5340

wants to merge 52 commits into from

Conversation

StickminBruv
Copy link
Contributor

@StickminBruv StickminBruv commented Apr 26, 2024 •
edited

Description

I made a new theme idea called cy red, based off a color someone made. It's my first time doing this stuff on github, so I know I messed up a lot.

image_2024-05-06_184542516

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Apr 26, 2024
@StickminBruv StickminBruv changed the title label(Adding_new_theme): pull request title (StickminBruv) Adding_new_theme (StickminBruv) Apr 26, 2024
@cobie8708
Copy link
Contributor

I believe that in order to follow the conventional commits standards, you must name your pull request "impr(themes): added and Created new theme"

@StickminBruv StickminBruv changed the title Adding_new_theme (StickminBruv) impr(themes): added and Created new theme Apr 27, 2024
@StickminBruv StickminBruv changed the title impr(themes): added and Created new theme impr(themes): added and Created new theme (StickminBruv) Apr 27, 2024
@Miodec
Copy link
Member

Miodec commented May 2, 2024

Text color must be close to white/black (can be slightly tinted).
Error color must be clearly visible (right now its very hard to spot).
Missing colors in the _list file (take a look at other themes)

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label May 2, 2024
@StickminBruv
Update _list.json
19a4ca9 
Added subcolor and textcolor to list to comply
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8938281407

@StickminBruv
Update _list.json
739b6a1 
Again, to comply
@StickminBruv
Update cy_red.css
a7298ad 
Changed multiple colors to comply
@StickminBruv
Copy link
Contributor Author

Text color must be close to white/black (can be slightly tinted). Error color must be clearly visible (right now its very hard to spot). Missing colors in the _list file (take a look at other themes)

I have now changed the text color, the error color, and the _list file
I believe the error color is still wrong, so correct me if I am really wrong with the error color

@Miodec
Copy link
Member

Miodec commented May 6, 2024

Please post some updated screenshots

@StickminBruv
Copy link
Contributor Author

Please post some updated screenshots

Updated screenshot for,comment

@Miodec
Copy link
Member

Miodec commented May 7, 2024

Errors are still not visible.

@StickminBruv
Update cy_red.css
43ed2ca 
Again, changed error color to comply
@StickminBruv
Copy link
Contributor Author

Changed again
Im definitely stuck in an endless loop, but that's alright

@Miodec
Copy link
Member

Miodec commented May 8, 2024

You cant really use red errors in a red theme..

extoplasm and others added 2 commits May 8, 2024 14:37
@extoplasm @Miodec
impr(quotes): created and added quotes in chinese simplified (extopla…
f5f3221 
…sm) (monkeytypegame#5333)

* added two quotes in chinese_simplified.json

* Update chinese_simplified.json

miscounted length of first quote

* updated quotes, added more

* Update chinese_simplified.json

miscounted quote lengths (again) (oops)
@cobie8708 @Miodec
impr(quotes): add english quote (cobie8708) (monkeytypegame#5338)
fc93e7c
Miodec and others added 26 commits May 8, 2024 14:37
@Miodec
impr(large test stats): better positioning on all screen sizes
1a0a1ab
@Miodec
fix(timer progress): mini and bar style not animating when shown
ef6ee20
@Miodec
style: improve banners
7752530
@Miodec
impr(numbers util): add roundTo1 function
c9ac33a
@Miodec
fix(result saving): dont save results if the tab was manually slowed …
41ec926 
…down
@Miodec
chore: remove unused code
a961abe
@Miodec
chore: add supporter
b0ea8b4
@Miodec
fix: enter not working as space in 58008 funbox if quick restart was …
05f9d54 
…set to enter
@Miodec
chore: allow user deletion again
064d64c
@Miodec
fix(bar timer progress): not animating for the first second of the test
e17012b
@shahnewaz-labib @Miodec
fix(word generation): display proper period and numbers for hindi (mo…
edbd699 
…nkeytypegame#5366)
@github-actions @monkeytypegeorge @Miodec
refactor: run prettier (monkeytypegame#5363)
287546b 
Co-authored-by: monkeytypegeorge <monkeytypegeorge@gmail.com>
@shahnewaz-labib @Miodec
fix(word generation): use correct fullstop and digits for bangla (sha…
6548ebb 
…hnewaz-labib) (monkeytypegame#5355)

* fix: add "।" instead of "." if bangla word

* fix: convert to bangla numerals
@extoplasm @Miodec
fix(quotes): replace /n with \n (extoplasm) (monkeytypegame#5356)
55dba32 
* added two quotes in chinese_simplified.json

* Update chinese_simplified.json

miscounted length of first quote

* updated quotes, added more

* Update chinese_simplified.json

miscounted quote lengths (again) (oops)

* accidentally did forward slash when doing newline

* fix length

---------

Co-authored-by: Jack <jack@monkeytype.com>
@Miodec
chore: release v24.19.0
4650419
@Miodec
fix(leaderboard modal): language selection dropdown position when scr…
02683ae 
…olling
@Miodec
fix: bailed out tests triggering inconsistent duration check
6ddd52e
@SpaceWaffles5827 @Miodec
fix: issue where '\n\n' was not rendering correctly in custom text (S…
58eac70 
…paceWaffles5827) (monkeytypegame#5370)

* fix: issue where '\n\n' was not rendering correctly in custom text

* fix: prettier styling
@Miodec
impr(commandline): add "add/remove quote to favorites" commands
4698d49 
closes monkeytypegame#5368
@Miodec
chore: remove daily lb which is no longer in the backend
24d131a
@Miodec
fix: dropdown element flashing for couple frames on page load
c458d17
@Miodec
feat(language): add japanese romaji 1k (nthngnssmnnglss)
6dbc3fd
@Miodec
fix: optional chaining
636b636 
!nuf
@Miodec
fix(words generator): infinite custom text tests not working correctly
f379438
@Miodec
chore: missing languages in list and group files
8e7c8b8
@Miodec
fix(language): remove duplicates
38d108a 
!nuf
@monkeytypegeorge monkeytypegeorge added the backend Server stuff label May 8, 2024
@Miodec
Copy link
Member

Miodec commented May 8, 2024

Sorry, looks like i broke your pr. If you work on the theme again please make a new PR. Again, sorry.

@Miodec Miodec closed this May 8, 2024
@StickminBruv
Copy link
Contributor Author

Sorry, looks like i broke your pr. If you work on the theme again please make a new PR. Again, sorry.

It's alright, I can just very easily copy and paste stuff
Also the comment about red errors in a red theme kinda makes sense now..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assets Languages, themes, layouts, etc. backend Server stuff frontend User interface or web stuff waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@StickminBruv @cobie8708 @Miodec @monkeytypegeorge @extoplasm @SheezZarR @tjkuson @shahnewaz-labib @SpaceWaffles5827