Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layouts): add Russian Mnemonic layout (nine0x09) #5305

Closed
wants to merge 3 commits into from

Conversation

nine0x09
Copy link

@nine0x09 nine0x09 commented Apr 13, 2024

Description

Added "Russian Mnemonic" keyboard layout. Reference image

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username inside parentheses at the end of the PR title

Closes #

Added Russian Mnemonic layout
@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Apr 13, 2024
@nine0x09 nine0x09 changed the title feat: Added Russian Mnemonic layout (nine0x09) feat(layouts): Added Russian Mnemonic layout (nine0x09) Apr 16, 2024
@nine0x09 nine0x09 changed the title feat(layouts): Added Russian Mnemonic layout (nine0x09) feat(layouts): add Russian Mnemonic layout (nine0x09) Apr 16, 2024
@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8708683004

@monkeytypegeorge
Copy link
Collaborator

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. https://github.com/monkeytypegame/monkeytype/actions/runs/8728184558

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Apr 23, 2024
@NadAlaba
Copy link
Contributor

Double quotes need escaping "2\""

Copy link
Contributor

github-actions bot commented May 5, 2024

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label May 5, 2024
@Miodec
Copy link
Member

Miodec commented May 6, 2024

Closing due to inactivity.

@Miodec Miodec closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff Stale Has not been updated in a while waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants