Broken MK_PLUGIN_{CHEETAH,LOGGER,TLS}

[ffontaine]

MK_PLUGIN_TLS is broken because it still uses mk_server_config which is not defined anywhere since c1c0445:

/home/buildroot/autobuild/run/instance-3/output-1/build/monkey-f54856ce250c4e25735434dc75717a4b7fbfc45b/plugins/tls/tls.c: In function 'mk_tls_plugin_init':
/home/buildroot/autobuild/run/instance-3/output-1/build/monkey-f54856ce250c4e25735434dc75717a4b7fbfc45b/plugins/tls/tls.c:734:42: error: dereferencing pointer to incomplete type 'struct mk_server_config'
  734 |     mk_list_foreach(head, &mk_api->config->listeners) {
      |                                          ^~

The issue is also affecting MK_PLUGIN_CHEETAH and MK_PLUGIN_LOGGER.

Full build log can be found here: http://autobuild.buildroot.org/results/da8/da87d2c9bf5afe52400f921d62c0ec777c9fe0a2/build-end.log

[rittneje]

Given the commit you linked, my guess is this line needs to be changed to struct mk_server *config;.

monkey/include/monkey/mk_plugin.h

Line 107 in 34ab0a1

struct mk_server_config *config;

The non-existent type is also referenced in a few other places.

monkey/include/monkey/mk_config.h

Line 197 in 34ab0a1

struct mk_server_config *mk_config_init();

monkey/mk_server/mk_config.c

Line 38 in 34ab0a1

struct mk_server_config *mk_config;

monkey/plugins/logger/logger.c

Line 364 in 34ab0a1

int mk_logger_master_init(struct mk_server_config *config)

Also, that mk_config_init() function is not defined anywhere, so that prototype should probably just be removed.