Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken MK_PLUGIN_AUTH #364

Open
cosmo0920 opened this issue Mar 29, 2022 · 3 comments
Open

Broken MK_PLUGIN_AUTH #364

cosmo0920 opened this issue Mar 29, 2022 · 3 comments

Comments

@cosmo0920
Copy link
Contributor

MK_PLUGIN_AUTH is broken because it still uses mk_server_config which is not defined anywhere since c1c0445:

~/GitHub/monkey/plugins/auth/conf.c:149:44: error: incomplete definition of type 'struct mk_server_config'
    struct mk_list *hosts = &mk_api->config->hosts;
                             ~~~~~~~~~~~~~~^
~/GitHub/monkey/include/monkey/mk_config.h:197:8: note: forward declaration of 'struct mk_server_config'
struct mk_server_config *mk_config_init();
       ^
1 error generated.
make[2]: *** [plugins/auth/CMakeFiles/monkey-auth-shared.dir/conf.c.o] Error 1
make[1]: *** [plugins/auth/CMakeFiles/monkey-auth-shared.dir/all] Error 2
make: *** [all] Error 2

The issue is also affecting as: #336

Step to replicate

  1. mkdir build && cd build
  2. Execute cmake -DMK_PLUGIN_AUTH=On ..
  3. Then, execute make
@leonardo-albertovich
Copy link
Collaborator

I think this will be deprecated really soon, @edsiper and I discussed a rather aggressive refactor, let me know if you want to be part of the discussion and get you up to speed!

@cosmo0920
Copy link
Contributor Author

Hmm…, I see. Marking as deprecated is reasonable.

@leonardo-albertovich
Copy link
Collaborator

I noticed you sent a PR to fix the issue so if it's good to go we'll merge it regardless, could you please confirm that it's ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants