Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP-PROXY tile #170

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Add HTTP-PROXY tile #170

wants to merge 2 commits into from

Conversation

jsdidierlaurent
Copy link
Member

@jsdidierlaurent jsdidierlaurent commented Feb 19, 2020 •
edited

  • core
  • ui
  • docs

Note: no faker mode for this one

fix #187

@codecov
Copy link

codecov bot commented Feb 19, 2020 •
edited

Codecov Report

Merging #170 into develop will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
+ Coverage    84.81%   84.99%   +0.18%     
===========================================
  Files          122      122              
  Lines         3430     3472      +42     
  Branches       109      109              
===========================================
+ Hits          2909     2951      +42     
  Misses         520      520              
  Partials         1        1
Flag Coverage Δ
#core 99.63% <100.00%> (+<0.01%) ⬆️
#ui 31.59% <100.00%> (+0.09%) ⬆️
Impacted Files Coverage Δ
models/tile.go 100.00% <ø> (ø)
models/tilevalue.go 100.00% <ø> (ø)
ui/src/components/TileIcon.vue 20.00% <ø> (ø)
monitorables/http/api/delivery/http/handlers.go 100.00% <100.00%> (ø)
monitorables/http/api/usecase/http.go 100.00% <100.00%> (ø)
monitorables/http/http.go 100.00% <100.00%> (ø)
ui/src/enums/tileType.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed95134...a4b9bce. Read the comment docs.

@jsdidierlaurent jsdidierlaurent force-pushed the add-HTTP-PROXY-tile branch 2 times, most recently from e5d9dfd to 9c30b67 Compare February 19, 2020 13:39
@Alex-D Alex-D changed the base branch from master to develop February 20, 2020 14:23
@Alex-D Alex-D changed the title feat(core/http): add HTTP-PROXY tile Add HTTP-PROXY tile Feb 28, 2020
@Alex-D Alex-D mentioned this pull request Mar 5, 2020
Open
@Alex-D Alex-D added this to the v3.1.0 milestone Mar 6, 2020
@Alex-D Alex-D added this to To do in 4.0 Mar 8, 2020
@Alex-D Alex-D removed this from the v3.2.0 milestone Mar 8, 2020
@Alex-D Alex-D removed this from To do in 4.0 Mar 8, 2020
@jsdidierlaurent jsdidierlaurent force-pushed the add-HTTP-PROXY-tile branch 2 times, most recently from 9cfc09a to b147dd0 Compare March 27, 2020 21:19
@jsdidierlaurent jsdidierlaurent force-pushed the add-HTTP-PROXY-tile branch 2 times, most recently from 79fbeb0 to 28c9007 Compare April 20, 2020 19:29
@Alex-D Alex-D marked this pull request as draft May 4, 2020 10:19
@Alex-D Alex-D added this to the v4.1.0 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-D Alex-D Awaiting requested review from Alex-D

Assignees
No one assigned
Labels
core documentation feature semver:minor
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Add HTTP-PROXY support
2 participants
@jsdidierlaurent @Alex-D