-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add typesense connector #7282
base: main
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ia a great PR. Congrats.
* @codeCoverageIgnore | ||
*/ | ||
public static function activated() | ||
public static function activated(): bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, if it's a boolean, the function should be isActivated
or something like that.
* | ||
* @codeCoverageIgnore | ||
*/ | ||
public static function indexed(): bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above. isIndexed
or something.
* | ||
* @codeCoverageIgnore | ||
*/ | ||
public static function fullTextIndex(): bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Adding
typesense
scout driver.Also fixing the
database
driver, and the ability to switch between drivers. We need to create the full text indexes on database, unless you explicitly set theSCOUT_FULL_TEXT_INDEX
variable tofalse
.