feat: Disable Signups for new users #7254
Conversation
|
|
phpunit.xml
Outdated
| @@ -8,6 +8,7 @@ | |||
| <testsuite name="Unit"> | |||
| <directory suffix="Test.php">./tests/Feature</directory> | |||
| <directory suffix="Test.php">./tests/Unit</directory> | |||
| <directory suffix="Test.php">./tests/PHPUnit</directory> | |||
There was a problem hiding this comment.
Please don't create another testsuite. Those tests should be placed under Unit
There was a problem hiding this comment.
@asbiin, Unit tests in Laravel are not a classic pure unit test, because they bootstrap the kernel, database, and much more. A pure unit test only works with abstractions and does not depend on anything, for this reason it is cleaner and faster. I can move the tests to the unit folder, but I would still suggest separating test types
| use Tests\TestCase; | ||
|
|
||
| class RegistrationTest extends TestCase | ||
| { | ||
| use DatabaseTransactions; | ||
|
|
||
| #[Test] | ||
| public function registration_screen_can_be_rendered() | ||
| public function testAccessToRegistrationPage(): void |
There was a problem hiding this comment.
@asbiin, it is enough that the name of the method begins with the word “test” and the phpunit recognizes it as a test method. The attribute is not needed here. see https://docs.phpunit.de/en/11.1/attributes.html#test
| protected function patchRoutes(): void | ||
| { | ||
| if ($this->app->routesAreCached()) { | ||
| return; | ||
| } | ||
|
|
||
| $router = $this->app->make(Router::class); | ||
| $routes = $router->getRoutes(); | ||
| collect(['create', 'store'])->each(function ($method) use ($routes) { | ||
| if ($route = $routes->getByAction(RegisteredUserController::class . '@' . $method)) { | ||
| $route->middleware('monica.signup_is_enabled'); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
This should go directly in the routes/web.php file, there is no need to "patch" the route
There was a problem hiding this comment.
@asbiin, no, it shouldn't be in the routes/web.php.
Routes and controller are part of the fortify package. I don’t want to redefine the entire route, we just need to add our custom middleware, that’s why we alter the routes in the service provider.
Co-authored-by: Alexis Saettler <alexis@saettler.org>
Co-authored-by: Alexis Saettler <alexis@saettler.org>
Co-authored-by: Alexis Saettler <alexis@saettler.org>
Co-authored-by: Alexis Saettler <alexis@saettler.org>
davpsh
changed the title
These changes allow to enable/disable new user registration based on ENV setting. The feature was implemented in version 4.x and was not present in chandler. Fixes #6687
Changes:
APP_DISABLE_SIGNUP