Update LifeMetrics.vue, line 229, solving 2 SonarCloud reliability bugs #7186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've done added what SonarCloud said the table defined on line 229 was missing, <th> headers and a description of the table (by using caption label). I hope this contribution is found helpful.
asbiin
requested changes
Mar 16, 2024
Comment on lines
+231
to
+236
| <caption style="caption-side: top;">Tabla de seguimiento del estado de ánimo por mes, | ||
| mostrando el número de eventos de seguimiento del estado de ánimo que ocurrieron en cada mes.</caption> | ||
| <thead> | ||
| <tr> | ||
| <th>Mes</th> | ||
| <th>Eventos</th> |
There was a problem hiding this comment.
We don't add hardcoded texts like that.
You must use the $t() function, and write the text in english. Then we can translate it in any languages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done added what SonarCloud said the table defined on line 229 was missing, headers and a description of the table (by using caption label). I hope this contribution is found helpful.