You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -1,5 +1,6 @@
1
1
### 0.8.4 (Next)
2
2
3
+
*[#250](https://github.com/mongoid/mongoid-history/pull/250): Migrate to Github actions - [@johnnyshields](https://github.com/johnnyshields).
3
4
*[#249](https://github.com/mongoid/mongoid-history/pull/249): Don't update version on embedded documents if the document itself is being destroyed - [@getaroom](https://github.com/getaroom).
4
5
*[#248](https://github.com/mongoid/mongoid-history/pull/248): Don't update version on embedded documents if an ancestor is being destroyed in the same operation - [@getaroom](https://github.com/getaroom).
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+16-17Lines changed: 16 additions & 17 deletions
Original file line number
Diff line number
Diff line change
@@ -1,9 +1,8 @@
1
-
Contributing to Mongoid-History
2
-
===============================
1
+
# Contributing to Mongoid-History
3
2
4
3
Mongoid-History is work of [many of contributors](https://github.com/mongoid/mongoid-history/graphs/contributors). You're encouraged to submit [pull requests](https://github.com/mongoid/mongoid-history/pulls), [propose features, ask questions and discuss issues](https://github.com/mongoid/mongoid-history/issues).
5
4
6
-
####Fork the Project
5
+
### Fork the Project
7
6
8
7
Fork the [project on Github](https://github.com/mongoid/mongoid-history) and check out your copy.
Make sure your fork is up-to-date and create a topic branch for your feature or bug fix.
19
18
@@ -23,7 +22,7 @@ git pull upstream master
23
22
git checkout -b my-feature-branch
24
23
```
25
24
26
-
####Bundle Install and Test
25
+
### Bundle Install and Test
27
26
28
27
Ensure that you can build the project and run tests.
29
28
@@ -32,29 +31,29 @@ bundle install
32
31
bundle exec rake
33
32
```
34
33
35
-
####Write Tests
34
+
### Write Tests
36
35
37
36
Try to write a test that reproduces the problem you're trying to fix or describes a feature that you want to build. Add to [spec/mongoid-history](spec/mongoid-history).
38
37
39
38
We definitely appreciate pull requests that highlight or reproduce a problem, even without a fix.
40
39
41
-
####Write Code
40
+
### Write Code
42
41
43
42
Implement your feature or bug fix.
44
43
45
44
Ruby style is enforced with [Rubocop](https://github.com/bbatsov/rubocop), run `bundle exec rubocop` and fix any style issues highlighted.
46
45
47
46
Make sure that `bundle exec rake` completes without errors.
48
47
49
-
####Write Documentation
48
+
### Write Documentation
50
49
51
50
Document any external behavior in the [README](README.md).
52
51
53
-
####Update Changelog
52
+
### Update Changelog
54
53
55
54
Add a line to [CHANGELOG](CHANGELOG.md) under *Next Release*. Make it look like every other line, including your name and link to your Github account.
56
55
57
-
####Commit Changes
56
+
### Commit Changes
58
57
59
58
Make sure git knows your name and email address:
60
59
@@ -70,17 +69,17 @@ git add ...
70
69
git commit
71
70
```
72
71
73
-
####Push
72
+
### Push
74
73
75
74
```
76
75
git push origin my-feature-branch
77
76
```
78
77
79
-
####Make a Pull Request
78
+
### Make a Pull Request
80
79
81
80
Go to https://github.com/contributor/mongoid-history and select your feature branch. Click the 'Pull Request' button and fill out the form. Pull requests are usually reviewed within a few days.
82
81
83
-
####Rebase
82
+
### Rebase
84
83
85
84
If you've been working on a change for a while, rebase with upstream/master.
86
85
@@ -90,7 +89,7 @@ git rebase upstream/master
90
89
git push origin my-feature-branch -f
91
90
```
92
91
93
-
####Update CHANGELOG Again
92
+
### Update CHANGELOG Again
94
93
95
94
Update the [CHANGELOG](CHANGELOG.md) with the pull request number. A typical entry looks as follows.
96
95
@@ -105,14 +104,14 @@ git commit --amend
105
104
git push origin my-feature-branch -f
106
105
```
107
106
108
-
####Check on Your Pull Request
107
+
### Check on Your Pull Request
109
108
110
109
Go back to your pull request after a few minutes and see whether it passed muster with Travis-CI. Everything should look green, otherwise fix issues and amend your commit as described above.
111
110
112
-
####Be Patient
111
+
### Be Patient
113
112
114
113
It's likely that your change will not be merged and that the nitpicky maintainers will ask you to do more, or fix seemingly benign problems. Hang on there!
115
114
116
-
####Thank You
115
+
### Thank You
117
116
118
117
Please do know that we really appreciate and value your time and work. We love you, really.
0 commit comments