fix(db): don't send session down to createIndex command

[vkarpov15]

Found another issue re: Automattic/mongoose#6109 (comment) . Looks like index builds always fail if retryWrites is turned on, for example:

run2.catch(error => console.error(error.stack));

async function run() {
  const { MongoClient } = require('mongodb');
  const client = await MongoClient.connect('mongodb://localhost:27017/test?retryWrites=true');

  await client.db('test').collection('test').createIndex({ email: 1 }, {
    unique: true
  });

  console.log('done');
}

Gives you a very unhelpful "Error: cyclic dependency detected" error. This will make it so that session doesn't make it into the return value from createCreateIndexesCommand()

[mbroadst]

@vkarpov15 I think you'll be happy to see mongodb-js/mongodb-core@d95a4d1 😄 Thanks for this fix as well! I'll port it to 3.1.x which will be released by tomorrow AM!

[mbroadst]

LGTM

[vkarpov15]

Nice! Can we also get another 3.0.x release so I can add this fix to mongoose 5.1.x?

[mbroadst]

yep! Today will be the final 3.0 release, and it will be moved to the stable tag. 3.1.0 will be released under latest tomorrow morning

[vkarpov15]

Thanks, looking forward to the last 3.0.x release 👍

[mbroadst]

@vkarpov15 you got it! Just released 3.0.11

[vkarpov15]

Thanks! Hope MongoDB World went well, looking forward to reading up on it when I get back to the states