chore(compass-saved-aggregation-queries): refactor of "My Queries" to support multiple connections COMPASS-7915

[himanshusinghs]

Description

This PR makes "My Queries" plugin work now with ConnectionsManager and InstancesManager instead of DataService and MongoDBInstance. Additionally, now, we don't rely anymore on singleConnectionConnectionInfo that we introduced at some point to render "My Queries" plugin. Instead, we have taken a more optimistic route which is to use useActiveConnections hook to get a hold of current active connections and work with the very first connection that we find, to render "CompassSidebar", "CompassShell" and interaction in "My Queries" plugin for single connection mode.

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added
• I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Open Questions

Dependents

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[paula-stacho]

I don't see the activeConnections being initialized when 'My Queries' is open - or is the store initialized when the plugin is included and not when 'My Queries' is open?

[paula-stacho]

In general I wonder if we could have a central place to fetch the active connections, instead of the plugins maintaining their own list. We have the useActiveConnections hook, which needs to be refactored and probably isn't of much use as it is, but perhaps we could work towards a reusable solution

[paula-stacho]

Also regarding the way we deal with single connection -> perhaps all these three questions are leading to the same -> could we use the same approach as in useActiveConnections? Get all connections from repository and use ConnectionsManager to filter for the connected ones? If I'm not mistaken, this should work for the initial state (when 'My Queries' is open), single connection.. and perhaps there is a way to make this reusable.

[himanshusinghs]

The active connections are getting initialised currently when we create the store, by listening to ConnectionsManager's events.

Regarding having some central place - Yea I think what we're looking for will be provided by compass-connections once we convert that to plugin and expose a service interface to provide the internals like activeConnections. That is surely the end goal.

[himanshusinghs]

I removed the activeConnections from the store given that the connectionRepository won't setup multiple subscriptions anymore (thanks to #5796). Will be using the hook in my next PR to address the connection selector. This one should be ready to go.
Reverted this because I realised we'd need to have some other thunk way to access activeConnections list and it would have ended up in ConnectionsManager which probably won't be nice.

[himanshusinghs]

Please check the updated description in the PR for the most recent update on this.

[gribnoysup]

I asked in another PR and I feel like it's worth asking again: do we ever expect in the code not to get data service back and handle it by not throwing an error when using manager in actions? Should this logic be part of the method if we always throw if data service is not returned? Same for instance model

[himanshusinghs]

Yea I am literally doing this if not throw everywhere, will definitely make this part of the getDataService interface. Thank you 👍

[gribnoysup]

Unsure why we need the switch on the feature flag here, this should be the same logic for both multi and single connection mode (with other auto-resolving logic):

Suggested change

	if (!multiConnectionsEnabled) {
	// In single connections mode, we only expect one connections to be here
	// in the list of active connections.
	const [activeConnection] = activeConnections;
	if (activeConnections.length === 1) {
	// If there is only one connection, try to resolve collection name to open the saved item without prompting for input
	const activeConnection = activeConnections[0];

[himanshusinghs]

Yea sorry for misdirection here - after our conversation I totally forgot to update / close this PR and left the work for the new modals and this branching in my other branch. I probably will close this one and will just raise one PR having both the changes.

[gribnoysup]

That's kind of an unexpected pattern, if you really want to use the action to get those values, you can throw right in the get method, no need to return an error to re-throw it, but also see my other comment: every place where we get those, we throw if value is not available, I feel like we should just make the getter method account for that so that we don't need to check everywhere