Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connection-form): add dynamic height to the form COMPASS-7895 #5792

Merged
merged 4 commits into from May 22, 2024
Merged

fix(connection-form): add dynamic height to the form COMPASS-7895 #5792

merged 4 commits into from May 22, 2024

Conversation

mabaasit
Copy link
Contributor

@mabaasit mabaasit commented May 8, 2024

fix-scroll-connection-form.mov

Description

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the fix label May 8, 2024
himanshusinghs
himanshusinghs approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@himanshusinghs himanshusinghs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mabaasit mabaasit added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label May 8, 2024
paula-stacho
paula-stacho approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@paula-stacho paula-stacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@mabaasit mabaasit merged commit d3c9174 into main May 22, 2024
11 of 15 checks passed
@mabaasit mabaasit deleted the COMPASS-7895-connection-form-scroll branch May 22, 2024 07:09
lerouxb added a commit that referenced this pull request May 23, 2024
@lerouxb
Revert "fix(connection-form): add dynamic height to the form COMPASS-…
e4d59a9 
…7895 (#5792)"

This reverts commit d3c9174.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lerouxb lerouxb lerouxb approved these changes

@paula-stacho paula-stacho paula-stacho approved these changes

@himanshusinghs himanshusinghs himanshusinghs approved these changes

Assignees
No one assigned
Labels
feature flagged PRs labeled with this label will not be included in the release notes of the next release fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mabaasit @lerouxb @paula-stacho @himanshusinghs