-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account settings swiftui rewrite , also - fixes #745 #1030
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thing is: this menu is also used for creating new accounts (the "add account (advanced)" button in the settings. Your PR breaks this functionality by not allowing users to cancel that process.
Really correct fix would be to allow some changes to be immediate without even closing the view (status message, shown username, new profile image), while having others (enable/disable account, change server etc.) need a verification.
That verification could be a simple alert asking the user if they want to save their changes and being displayed if a user tries to close the view without saving the changes first.
6269c32
to
7ee93f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me reiterate:
Thing is: this menu is also used for creating new accounts (the "add account (advanced)" button in the settings. Your PR breaks this functionality by not allowing users to cancel that process.
Really correct fix would be to allow some changes to be immediate without even closing the view (status message, shown username, new profile image), while having others (enable/disable account, change server etc.) need a verification.
That verification could be a simple alert asking the user if they want to save their changes and being displayed if a user tries to close the view without saving the changes first.
6495b90
to
a2c7a56
Compare
36c6c66
to
2a92c7a
Compare
b8ed218
to
ae4764f
Compare
as described in the original issue
" What happened?
Go to Settings
Go to your account
Deactivate the account toggle
Leave the menu
Nothing changed "
--> Monal should ask you if you want to confirm your changes - or just do it on change"
It will autosave when user will exit the screen