Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #5489 #5490

Closed
wants to merge 2 commits into from
Closed

Fixes issue #5489 #5490

wants to merge 2 commits into from

Conversation

dwsmart
Copy link

@dwsmart dwsmart commented May 1, 2020

Fixes issue #5489 by changing these lines from:

 aliasedRequire(
                (typeof __dirname !== undefined ? __dirname : '.') +
                    '/locale/' +
                    name
            );

To:

aliasedRequire(
                `${typeof __dirname !== undefined ? __dirname : '..'}/locale/${name}`
            );

@coveralls
Copy link

coveralls commented May 1, 2020

Coverage Status

Coverage remained the same at 88.468% when pulling f4cbef6 on dwsmart:fix-for-5489 into 36a817d on moment:develop.

@ichernev
Copy link
Contributor

ichernev commented May 1, 2020

@dwsmart can you try latest develop, I merged something to fix the typeof. Also, in 2.24.0 the code was just './locale' + name, so I'm not just changing it to '../locale' + name.

@dwsmart
Copy link
Author

dwsmart commented May 1, 2020

@ichernev, yes latest develop version seems to have addresses the issue, not sure why it had to be '../locale' instead of ./locale' but that was required to fix. Probably my misunderstanding of something. I'll close the pull request.
Thanks!

@dwsmart dwsmart closed this May 1, 2020
@dwsmart dwsmart deleted the fix-for-5489 branch May 1, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants