Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: missing TS3.1 typings in npm package. #5487

Closed
wants to merge 1 commit into from

Conversation

djcsdy
Copy link

@djcsdy djcsdy commented May 1, 2020

Fixes missing TypeScript 3.1 typings in the npm package for moment. Fixes #5486.

Since 2.25.0, package.json specifies:

    "typesVersions": {
        ">=3.1": {
            "*": [
                "ts3.1-typings/*"
            ]
        }
    },

but the ts3.1-typings folder was not included in the npm package.

@jsf-clabot
Copy link

jsf-clabot commented May 1, 2020

CLA assistant check
All committers have signed the CLA.

@djcsdy djcsdy changed the title Fix missing TS3.1 typings in npm package. bugfix: missing TS3.1 typings in npm package. May 1, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.468% when pulling 8c627d4 on djcsdy:ts3.1-missing into 36a817d on moment:develop.

@alexturek
Copy link

I believe the title needs to begin with [bugfix] (including the brackets)

@alexturek
Copy link

Ah - fixed in 6e32433

So I believe the fix is already in, we just need a new release of 2.25

@ichernev
Copy link
Contributor

ichernev commented May 1, 2020

@alexturek yes, I made the change myself. Thanks @djcsdy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS2307: Cannot find module 'moment'.
5 participants