Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg] webpack,babel: Make require path cross-platform #4045

Closed
wants to merge 1 commit into from
Closed

[pkg] webpack,babel: Make require path cross-platform #4045

wants to merge 1 commit into from

Conversation

soundstripe
Copy link

fixes an issue when compiling with webpack/babel on Windows

issues: #2979, #4031, #3872,

@soundstripe
make require path cross-platform
72d63bd 
fixes an issue when compiling with webpack/babel on Windows
@jsf-clabot
Copy link

jsf-clabot commented Jun 28, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@ichernev
Copy link
Contributor

ichernev commented Aug 3, 2017

@ovangle #4042 seems related somewhat.

@ichernev ichernev changed the title make require path cross-platform [pkg] webpack,babel: Make require path cross-platform Aug 3, 2017
@ovangle
Copy link
Contributor

ovangle commented Aug 3, 2017

@ichernev
Yeah, node doesn't care what the path separator is in the target environment -- #4042 is the correct fix for this issue.

@ichernev
Copy link
Contributor

Closing this for now, as @ovangle's change broke the world, and this doesn't seem to fix things either.

@ichernev ichernev closed this Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@soundstripe @jsf-clabot @ichernev @ovangle