[bugfix] parseZone should handle UTC #3523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woah! Pull request from @icambron. I am so excited. |
|
@mj1856 Interesting, hadn't seen that. Each fix suffices on their own to fix the specific issue. His is better for the ISO case, but mine also handles additional cases. The right answer is to just take both. |
|
Great. I'll merge both. |
|
Merged in 66721ca |
ichernev
changed the title
ichernev
added a commit
that referenced
this pull request
Nov 6, 2016
[bugfix] parseZone should handle UTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3520 and #3521, where
parseZonedoesn't handle UTC correctly. Specifically, we need to treat parsing0out of the string differently from failing to parse it at all.