Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banditypes #1034

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add banditypes #1034

wants to merge 1 commit into from

Conversation

thoughtspile
Copy link

@thoughtspile thoughtspile commented Feb 28, 2023

Hey @moltar, thanks for the excellent infrastructure to benchmark validation performance, this saved me a lot of time! I went ahead of myself and added my library, banditypes. Turns out it's not only the smallest one, but also reasonably fast.

BTW if you aim for pinning exact versions of tested packages, why not add save-exact=true to .npmrc instead of commenting this on all PRs?

@moltar
Copy link
Owner

moltar commented Feb 28, 2023

Hey @thoughtspile, thanks for the submission 🤜🏼

However, it seems like the test is failing:

Error: node_modules/banditypes/dist/index.d.ts(35,138): error TS2344: Type 'T[K]' does not satisfy the constraint '(...args: any) => any'.
  Type 'T[keyof T]' is not assignable to type '(...args: any) => any'.
    Type 'T[string] | T[number] | T[symbol]' is not assignable to type '(...args: any) => any'.
      Type 'T[string]' is not assignable to type '(...args: any) => any'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants