feat(mongodb): add extended config options for MongoDB #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisdaly
requested review from
elnyry-sam-k,
mdebarros,
oderayi,
shashi165,
vgenev and
vijayg10
as code owners
lewisdaly
commented
Mar 31, 2021
| @@ -85,7 +85,7 @@ | |||
| "@hapi/inert": "6.0.3", | |||
| "@hapi/joi": "17.1.1", | |||
| "@hapi/vision": "6.0.1", | |||
| "@mojaloop/central-object-store": "11.0.0-snapshot", | |||
| "@mojaloop/central-object-store": "git://github.com/vessels-tech/central-object-store.git#feat/2100-add-tls-config", | |||
There was a problem hiding this comment.
Blocked by mojaloop/object-store-lib#21
85 tasks
lewisdaly
commented
Apr 14, 2021
| @@ -314,6 +314,7 @@ Test('Participant service', async (participantTest) => { | |||
| } | |||
| }) | |||
|
|
|||
| // TODO: these integration tests are failing... | |||
lewisdaly
commented
Apr 14, 2021
| @@ -401,6 +408,7 @@ Test('Handlers test', async handlersTest => { | |||
| test.end() | |||
| }) | |||
|
|
|||
| // TODO: fix this test! | |||
lewisdaly
commented
Apr 14, 2021
| // Act | ||
| await sleepPromise(15) // give the timeout handler some time to expire the request | ||
| const payerCurrentPosition = await ParticipantService.getPositionByParticipantCurrencyId(td.payer.participantCurrencyId) || {} | ||
| // TODO: fix me! |
lewisdaly
commented
Apr 14, 2021
| @@ -151,6 +145,8 @@ Test('setup', setupTest => { | |||
| test.end() | |||
| }) | |||
|
|
|||
| // TODO: this testis invalid - the error is `TypeError: server.ext is not a function` | |||
|
@lewisdaly , this for the PR :-) Would it be possible to bring this up to date, so that we can review & merge it? If not its getting stale and we may have to close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of mojaloop/project#2100