feat(mojaloop/#3904): add position event timeout reserved batch handling #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleyow
commented
May 14, 2024
| // Enum.Accounts.TransferParticipantRoleType.PAYEE_DFSP, | ||
| // Enum.Accounts.LedgerEntryType.PRINCIPLE_VALUE | ||
| // ) | ||
| // Is it safe using this value of the payee even accounting for the negative value? |
There was a problem hiding this comment.
After dicussions this value is safe to use to revert the payer's position.
kleyow
commented
May 14, 2024
| payeeFsp, | ||
| payerFsp, | ||
| metadata, | ||
| headers, // Unsure what headers need to be passed here |
There was a problem hiding this comment.
🤔 couldn't tell from the non batch code what the headers for this are.
There was a problem hiding this comment.
The ml-api-adapter deals with notifying the payee and payer, so headers don't matter and the adapter will construct the proper headers!
https://github.com/mojaloop/ml-api-adapter/blob/main/src/handlers/notification/index.js#L545
As long as the to and from are the payer and payee, which they have been and the action is timeout-reserved ml adapter will notify both.
17 tasks
vijayg10
reviewed
May 17, 2024
test/integration-override/handlers/positions/handlerBatch.test.js
Outdated
Show resolved
Hide resolved
|
vijayg10
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#3904): add position event timeout reserved batch handling