Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added expected JSON response on successful execution of endpoints for FLINT Example. #200

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: added expected JSON response on successful execution of endpoints for FLINT Example. #200

wants to merge 4 commits into from

Conversation

Freeman-kuch
Copy link

Description

Updated the Curl.md to show expected Responses on successful execution of endpoints of FLINT example.

Fixes #186

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested using the Preview Functionality on VScode.

preview of curl

Also works Fine on GitHub

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

Namyalg
Namyalg previously approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@Namyalg Namyalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
cc : @padmajabhol

HarshCasper
HarshCasper requested changes Oct 18, 2022
View reviewed changes
Copy link
Member

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSON and CSV response is not indented as per the rest of the documentation.

@Freeman-kuch
Copy link
Author

The JSON and CSV response is not indented as per the rest of the documentation.

alright, Working on it

@Freeman-kuch
updated curl.md
34f2652 
Signed-off-by: Freeman <freemanoparaocha@gmail.com>
@Freeman-kuch
properly indented expected JSON and CSV responses
007dcec 
Signed-off-by: Freeman <freemanoparaocha@gmail.com>
@Freeman-kuch Freeman-kuch requested review from Namyalg and removed request for HarshCasper October 18, 2022 14:00
@aornugent
Copy link
Contributor

@HarshCasper - are you happy with the latest changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshCasper HarshCasper HarshCasper requested changes

@Namyalg Namyalg Awaiting requested review from Namyalg

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
DO-NOT-MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add expected JSON response on successful execution of endpoints for FLINT Example
4 participants
@Freeman-kuch @aornugent @HarshCasper @Namyalg