Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added a new GCBM status endpoint #180

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

SanjaySinghRajpoot
Copy link
Contributor

Pull Request Template

Description

A new endpoint is created called /gcbm/status. This endpoint will return the status of the running GCBM simulation and the logs generated in simulation.txt. This endpoint will be called by the FLINT-UI to get the latest status of the GCBM simulation. In this manner, the user will be able to check if everything is working correctly or if there is any error. If the simulation is not running a 400 status will be returned to the user.

Fixes #179

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Screenshot_20220907_172437

It has been tested on a local host. The above image giving a error message as no simulation is running.

Copy link
Member

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests continue to fail. Can you validate once again?

@SanjaySinghRajpoot
Copy link
Contributor Author

The test case is failing for some other endpoint of GCBM simulation. Earlier I added some test cases for this endpoint they were not working as expected so I had to remove them. I am working on adding some new test cases for this endpoint.

@aornugent
Copy link
Contributor

@SanjaySinghRajpoot @HarshCasper - what is the status of this PR?

@SanjaySinghRajpoot
Copy link
Contributor Author

The test cases are failing for this some other endpoint in this PR. In this PR we are trying to get the status of GCBM simulation, using /status endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new GCBM endpoint to check the simulation status
3 participants