Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Consolidate accuracy charts and functions #2147

Closed
wants to merge 9 commits into from

Conversation

RobinL
Copy link
Member

@RobinL RobinL commented Apr 23, 2024

Consolidates

truth_space_table_from_labels_{type}
roc_chart_from_labels_{type}
precision_recall_chart_from_labels_{type}
accuracy_chart_from_labels_{type}
threshold_selection_tool_from_labels_{type}

to

accuracy_analysis_from_labels_{type}

Where {type} is either 'table' or 'column

Questions:

  • Should truth_space_table_from_labels_ be a separate function, since its return type is different?
  • Should we bother retaining the precision_recall and roc options?

Closes #2010

@RobinL RobinL changed the base branch from master to splink4_dev April 23, 2024 07:01
@RobinL RobinL changed the title Consolidate accuracy (WIP) Consolidate accuracy charts and functions Apr 23, 2024
@RobinL RobinL mentioned this pull request May 17, 2024
@RobinL
Copy link
Member Author

RobinL commented May 17, 2024

Closing in favour of #2187

@RobinL RobinL closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant