-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve modify layout #1525
base: master
Are you sure you want to change the base?
Improve modify layout #1525
Conversation
Moving the "You may recover your draft ..." flash message to the bottom makes it less useful in that some/most editors would not realize a draft was available until they finish re-editing and scroll to the bottom to click the save button. You could also delete the |
In this case it really makes sense to show the flash on top of the page. I will have to take a look how it's possible to use the flash in two different places: On at the top and one where the buttons are.
Alright |
I'm not sure what the best way is to solve this. Here is an idea: We could use a HTML element at the top and at the bottom (where the buttons are) with class This would only work if the text was not translated at that point but I'm not sure if that is the case. A disadvantage is that at everytime someone changes the text of the message this part has also to be updated. This example is for illustration of the idea:
|
You can try the categories feature of flashing, see https://tedboy.github.io/flask/patterns/flashing.html#flashing-with-categories. When you change the category to 'info-top' you can filter it in the template, e.g.:
By the way, I am preparing a change regarding translations, which could also change some text phrases. IMO, using the msg text in an if statement is not an option. |
In most forms the buttons to confirm or cancel are at the bottom because in western countries we read from top to bottom. Because of that this PR moves the buttons for confirmation, cancellation and preview to the bottom. It also changed the order of the buttons because usually a button on the right lets users do anything to go on and a button on the left lets them go back. It also has to do something with how we read (from left to right; the right site is the "future").
The next change is that I also moved the alerts to the bottom because the feedback has to be where the buttons for interaction are.
This PR affects at least the basic and the modernized theme.