fix: parse array rather than string, so that quotes are safe (yargs#993)

moimikey · Oct 21, 2017 · c351685 · c351685
1 parent 0684741
commit c351685
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/lib/command.js b/lib/command.js
@@ -318,15 +318,16 @@ module.exports = function command (yargs, usage, validation) {
 
     const unparsed = []
     Object.keys(positionalMap).forEach((key) => {
-      [].push.apply(unparsed, positionalMap[key].map((value) => {
-        return `--${key} ${value}`
-      }))
+      positionalMap[key].map((value) => {
+        unparsed.push(`--${key}`)
+        unparsed.push(value)
+      })
     })
 
     // short-circuit parse.
     if (!unparsed.length) return
 
-    const parsed = Parser.detailed(unparsed.join(' '), options)
+    const parsed = Parser.detailed(unparsed, options)
 
     if (parsed.error) {
       yargs.getUsageInstance().fail(parsed.error.message, parsed.error)