Fix problem when put whitespace in search inbox. #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mehdi-git
changed the title
Wave6677
added a commit
to Wave6677/qksms
that referenced
this pull request
May 15, 2023
Pull moezbhatti#1786 by Mehdi-git on May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #1776
When you type spaces in search inbox (a blank query), map operator convert the query to an empty query by trim() method. Then app starts searching for an empty query and gets into the not responding state.
I moved the map operator before withLatestFrom operator, So empty query gets involved in withLatestFrom if statement.