Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a cache provider for caching to RethinkDB #91

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

Added a cache provider for caching to RethinkDB #91

wants to merge 2 commits into from

Conversation

Omeryl
Copy link
Member

@Omeryl Omeryl commented Apr 16, 2016

It's missing a few things, but functionally it works.

Things that can be improved upon:

  • It could probably do with some more error handling.
  • While I store an expiration date, I'm currently not checking it.
  • Clearing a cache with a wildcard just flushes the entire cache.
  • Flushing flushes everything, not just the specified partition.

/*
* This file is part of xPDO.
*
* Copyright (c) Elizabeth Southwell <
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should just be the standard MODX/xPDO copyright line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@opengeek opengeek modified the milestone: 3.0.x-beta Jan 16, 2017
@opengeek
Copy link
Member

My concern here is that each partition should be separate and protected from flushes. If this still flushes all partitions when you call it on a specific partition, then I'd like to see that resolved before incorporating this into mainline.

@opengeek opengeek modified the milestones: 3.0.x-beta, 3.0.0, 3.1.0 Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants