Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance textarea tv type #16553

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

Enhance textarea tv type #16553

wants to merge 1 commit into from

Conversation

smg6511
Copy link
Collaborator

@smg6511 smg6511 commented Apr 3, 2024

What does it do?

Adds new input options to control input height.

Why is it needed?

Currently this input type is restricted to its default size of 140px.

How to test

  1. Rebuild the manager template (cd to _build/templates/default and run grunt build)
  2. Clear MODX caches
  3. Create a few textarea type TVs to test the three new options (height, auto grow, and resize)

Related issue(s)/PR(s)

Resolves #5512

Adds new input options to control input height
@smg6511 smg6511 added the requires build Grunt build is required for integration label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 21.55%. Comparing base (1b01af2) to head (1512af8).
Report is 3 commits behind head on 3.x.

Files Patch % Lines
...mplateVar/Configs/mgr/inputproperties/textarea.php 0.00% 29 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.x   #16553      +/-   ##
============================================
- Coverage     21.57%   21.55%   -0.02%     
  Complexity    10577    10577              
============================================
  Files           561      561              
  Lines         31975    32003      +28     
============================================
  Hits           6898     6898              
- Misses        25077    25105      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mark-H Mark-H added this to the v3.1.0 milestone Apr 8, 2024
@smg6511 smg6511 added the pr/review-needed Pull request requires review and testing. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/review-needed Pull request requires review and testing. requires build Grunt build is required for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TV input type "textarea" not high enough
2 participants