Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Element handling from within Categories tree #16546

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

opengeek
Copy link
Member

What does it do?

Adds a new tree method to properly extract Element data from the working
tree Node. There are three patterns for a Node's id, but only one was
being accounted for in the code. Additionally, cleans up code formatting
in the affected methods.

Why is it needed?

Within the Categories tree, these actions are currently inoperable:

  • Element removal
  • Plugin activation/deactivation

How to test

  1. Create a handful of Elements (at least one of each type), both within
    a Category and within the root (no Category)
  2. Verify the ability to remove each Element (from both the Categories
    tree and from within the individual Element trees)
  3. Verify the ability to activate/deactivate Plugins (from both the
    Categories tree and from within the individual Element trees)

Related issue(s)/PR(s)

Resolves #16487 for MODX 3.0.x
Related to 2.x solution #16488
Port of 3.x solution #16489

smg6511 and others added 3 commits March 25, 2024 09:13
Fix contextual menu action functionality within Categories tree
Refactor new extraction method to account for Element creation in the root of its tree
@opengeek opengeek requested a review from Mark-H as a code owner March 25, 2024 15:18
@opengeek opengeek merged commit e5055c4 into modxcms:3.0.x Mar 25, 2024
7 checks passed
@opengeek opengeek deleted the 3.0.x-16489 branch March 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants